[Solana] Allowlist on token pool #564
Draft
+1,865
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloMansanet
changed the title
agusaldasoro
requested changes
Feb 6, 2025
| old_authority, | ||
| new_authority | ||
| }); | ||
| Ok(()) | ||
| } | ||
|
|
||
| // set_router changes the router program ID. This is used to derive the list | ||
| // of valid mint/release callers (offramps). | ||
| pub fn set_router(ctx: Context<SetConfig>, new_router: Pubkey) -> Result<()> { |
There was a problem hiding this comment.
could this method be cyclic in some way? Is that a concern?
There was a problem hiding this comment.
Not sure what you mean exactly about cyclic in this case 🤔
This method may only be invoked by the pool owner, not the router. Then, the router address here is used just to later check if the calling offramp is a valid one or not.
I've checked a bit and we already have another field in the pool though called ramp_authority that has the onramp address... And that's always the same as the router address, so we could just reuse it (even though in EVM they are separate concepts, here they are pretty much the same thing....)
|
can we add a test (if not present) of removing an offramp and then checking for it? |
toblich
force-pushed
the
allowed_offramps_tokenpool
branch
from
f254857 to
cd69649
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the approach taken for the example receiver.
TokenOfframptakes a whitelisted offramp as signer, butTokenOnrampcontinues to use the router as signer, as before.